Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to 1.2.x: CSI: skip node unpublish on GC'd or down nodes #14720

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 27, 2022

#13301 was supposed to have been backported to 1.2.x but there's no backport tag. Weirdly, #13311 refers to the code having been backported, and the test changes from #13301 are already here, just not the code changes. Not sure how that happened but #13301 was one of the PRs impacted by the weirdness around the 1.3.2 vs 1.3.5 release. In any case, this bug should get released in the next 1.2.x.

(1/2 PRs, the other will be for 1.1.x)

@shoenig
Copy link
Member

shoenig commented Sep 27, 2022

Maybe botched conflict resolution?

@tgross tgross merged commit 0735ed3 into release/1.2.x Sep 27, 2022
@tgross tgross deleted the backport/13301-to-1.2.x branch September 27, 2022 14:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants